Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get only vcards which match both the address book id and the vcard uri #25294

Merged
merged 1 commit into from Jun 29, 2016

Conversation

schiessle
Copy link
Contributor

getContact() should only return contacts which match both the address book id and the vcard uri

This is just a one-liner, so there shouldn't be any copyright issues. But if you prefer, I hereby grant you permission to use it under the MIT license.

cc @DeepDiver1975 @PVince81

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @DeepDiver1975, @nickvergessen and @georgehrke to be potential reviewers

@DeepDiver1975 DeepDiver1975 added this to the 9.1-current milestone Jun 28, 2016
@DeepDiver1975
Copy link
Member

Thanks @schiessle - I assume this also affects 9.0.x - right?

@schiessle
Copy link
Contributor Author

@DeepDiver1975 didn't checked it but most likely this needs to be backported

@ghost
Copy link

ghost commented Jun 28, 2016

@schiessle

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@georgehrke
Copy link
Contributor

👍 good catch

@DeepDiver1975
Copy link
Member

unit tests are green as well 👍

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants